Skip to content

Doc: Fix typos#125728

Merged
erlend-aasland merged 1 commit into
python:mainfrom
ember91:ember91/fix_typos_doc
Oct 21, 2024
Merged

Doc: Fix typos#125728
erlend-aasland merged 1 commit into
python:mainfrom
ember91:ember91/fix_typos_doc

Conversation

@ember91

@ember91 ember91 commented Oct 19, 2024

Copy link
Copy Markdown
Contributor

@bedevere-app

bedevere-app Bot commented Oct 19, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@skirpichev

Copy link
Copy Markdown
Member

This affects also C sources.

@AA-Turner

Copy link
Copy Markdown
Member

@ember91 please revert all changes to Modules/

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all changes to Modules/

@bedevere-app

bedevere-app Bot commented Oct 19, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@bedevere-app

bedevere-app Bot commented Oct 19, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@ember91

ember91 commented Oct 19, 2024

Copy link
Copy Markdown
Contributor Author

Please revert all changes to Modules/

Done. No idea how that happened.

@ember91

ember91 commented Oct 19, 2024

Copy link
Copy Markdown
Contributor Author

This affects also C sources.

Fixed, by reverting changes to Modules/

@willingc willingc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for correcting this PR. @AA-Turner this PR now addresses changes to .rst files.

@ember91 I encourage you to choose an open issue for a future PR and expanding beyond typo fixes. Thanks!

@willingc willingc added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 19, 2024
@erlend-aasland erlend-aasland dismissed AA-Turner’s stale review October 21, 2024 08:43

All changes to Modules/ have been reverted, as per Adam's request.

@erlend-aasland erlend-aasland changed the title Doc: Fix typos in Doc/ Doc: Fix typos Oct 21, 2024
@erlend-aasland erlend-aasland merged commit ded105a into python:main Oct 21, 2024
@miss-islington-app

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2024
(cherry picked from commit ded105a)

Co-authored-by: ember91 <31469580+ember91@users.noreply.github.com>
@miss-islington-app

This comment was marked as outdated.

@bedevere-app

bedevere-app Bot commented Oct 21, 2024

Copy link
Copy Markdown

GH-125773 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Oct 21, 2024
erlend-aasland pushed a commit that referenced this pull request Oct 21, 2024
(cherry picked from commit ded105a)

Co-authored-by: ember91 <31469580+ember91@users.noreply.github.com>
@erlend-aasland erlend-aasland removed the needs backport to 3.12 only security fixes label Oct 21, 2024
@erlend-aasland

Copy link
Copy Markdown
Contributor

Sorry, @ember91 and @erlend-aasland, I could not cleanly backport this to 3.12 due to a conflict. Please backport using cherry_picker on command line.

Let's not bother with the 3.12 since it does not apply cleanly.

ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants